Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Pod spec does not contain a template container called 'task-runner'" error message swallowed #371

Merged
merged 2 commits into from
Oct 30, 2018
Merged

"Pod spec does not contain a template container called 'task-runner'" error message swallowed #371

merged 2 commits into from
Oct 30, 2018

Conversation

dturn
Copy link
Contributor

@dturn dturn commented Oct 26, 2018

Noticed this when messing around with something else. The runner fails, but the lack of reason is a bit frustrating. I'm working on a fix.

cc: @KnVerey

[INFO][2018-10-25 17:10:32 -0700]	
[INFO][2018-10-25 17:10:32 -0700]	-------------------------------------Phase 1: Initializing task-------------------------------------
[INFO][2018-10-25 17:10:32 -0700]	Validating configuration
[INFO][2018-10-25 17:10:32 -0700]	Using namespace 'k8sdeploy-test-run-with-pod-spec-template-miss-16381c175df4feeb' in context 'minikube'
[INFO][2018-10-25 17:10:32 -0700]	Using template 'hello-cloud-template-runner'
[INFO][2018-10-25 17:10:32 -0700]	
[INFO][2018-10-25 17:10:32 -0700]	------------------------------------------Result: FAILURE-------------------------------------------
[INFO][2018-10-25 17:10:32 -0700]	
[INFO][2018-10-25 17:10:32 -0700]	-------------------------------------Phase 1: Initializing task-------------------------------------
[INFO][2018-10-25 17:10:32 -0700]	Validating configuration
[INFO][2018-10-25 17:10:32 -0700]	Using namespace 'k8sdeploy-test-run-with-pod-spec-template-miss-16381c175df4feeb' in context 'minikube'
[INFO][2018-10-25 17:10:32 -0700]	Using template 'hello-cloud-template-runner'
[INFO][2018-10-25 17:10:32 -0700]	
[INFO][2018-10-25 17:10:32 -0700]	------------------------------------------Result: FAILURE-------------------------------------------

@dturn dturn changed the title "Pod spec does not contain a template container called 'task-runner'swallowed" error message swallowed "Pod spec does not contain a template container called 'task-runner'" error message swallowed Oct 26, 2018
@KnVerey
Copy link
Contributor

KnVerey commented Oct 26, 2018

Yep, that's probably a regression from the refactoring we did to the runner in adding log streaming. FYI I have a WIP branch to improve and centralize validations for all our tasks: https://github.com/Shopify/kubernetes-deploy/compare/config_validator. I think it's ok to make a quick fix + regression test here and then I'll make sure my PR covers the root cause of us not noticing this.

@dturn dturn merged commit c92bcfd into master Oct 30, 2018
@dturn dturn deleted the runner-error-swallowed branch October 30, 2018 18:21
@dturn dturn temporarily deployed to rubygems November 14, 2018 23:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey KnVerey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dturn @KnVerey